Srirama, Looks okay to me
Paul Srirama Sharma wrote: > Hi Paul, > > Thanks for the review. > > Have included the 'sunman-stability' section and 'Notes' section into > the *.1 files itself. > > Please review the modified webrev at > http://cr.opensolaris.org/~srirama/simplewbem/ > > Thanks, > Srirama > > Paul Cunningham said the following on Wednesday 26 November 2008 01:32 PM: >> Srirama, >> >> Srirama Sharma wrote: >> ... cut ... >> >>> Have updated the webrev at >>> http://cr.opensolaris.org/~srirama/simplewbem/ with all the above changes. >>> >>> Please review. >>> >> >> This mainly looks good to me now, except ... >> >> > >> >> 2. usr/src/cmd/simplewbem/*.1 >> >> Did you write these man pages, if so you might need >> >> to add the Sun copyright and CDDL stuff. >> >> >> > and have removed the sunman-stability section. >> >> don't you need that, either directly in the *.1 files or using the >> sunman-stability modification method with '_install M ...'in >> simplewbem/install-sfw ? >> >> Paul >> -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
