Martina, See my comments below from my quick skip through ..
Paul > -----Original Message----- > From: sfwnv-discuss-bounces at opensolaris.org > [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of > Martina Tomisova > Sent: 01 July 2008 12:25 > To: sfwnv-discuss at opensolaris.org > Subject: [sfwnv-discuss] review request - integrating ngrep > > Hi, > > I've prepared changes for including ngrep into Nevada. There > is a webrev so you can check it. Any comments are welcomed. > PSARC is not approved yet. > > http://cr.opensolaris.org/~martina/ngrep/ === Start of comments === 1. usr/src/cmd/ngrep/Makefile.sfw You may want to change so it uses the predefined '--prefix=..' from Makefile.master; something like: CONFIGURE_OPTIONS += --enable-ipv6 .... ./configure $(CONFIGURE_OPTIONS) 2. usr/src/cmd/ngrep/install.sfw Why the 'for' loop for one item, and why the 'mv' after '_install' ? Couldn't this just be .. _install M ${VERS}/ngrep.8 ${ROOTDIR}/${MAN8DIR}/ngrep.8 Is 8 the right man section for this page on solaris? (just checking). 3. Everything else looks okay to me :-) === End of comments =====
