Hi Lei Chen, Thanks a lot for your comments. Please see inline for my answers.
The latest webrev is at: http://cr.opensolaris.org/~linguo/snack/ Lei Chen wrote: > 1. Please put your newly added items in alphabetic order in usr/src/Targetdirs > Done. > 2. same as above in usr/src/lib/Makefile > Done. > 3. I'm not clear you specify a mapfile in the LDFLAGS for what purpose in the > Makefile.sfw. > To be on the safe side, picking up "no-exec-stack" mapfile. > 4. If the install-sfw-64 doesn't have much work other than install two 64bit > binary, I think maybe this file can be merged with install-sfw. > I think it would be more clear than merging all together. I found the similar designed packages also, such as libedit & memcached. > 5. Where's the file pkgIndex.tcl from? Should a copyright notice be added? > In general, the file "pkgIndex.tcl" is created by pkg_mkIndex utility for Tcl Extensions, that's why such files have no copyright. To support both 32bit and 64bit libraries, I modified the file a little,but most of the content are created by the utility. So I didn't add a copyright. Best Regards, Lin > Regards, > Lei Chen > > > This message posted from opensolaris.org > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
