Chris -
Here are a few comments so far.
1. Your METADATA file is incomplete. See some of the other submitted METADATA
files for
details of what should be there.
2. Why are you removing the ircii lines in usr/src/cmd/Makefile and
usr/src/pkgdefs/Makefile?
3. In the standard build of mtx, the executables are installed in sbin rather
than bin. Do you think
bin is better? Your install-sfw puts things in bin.
4. In your pkginfo.tmpl file, no where do I find the version 1.3.11
information. Actually, looking
at some other recent pkginfo.tmpl files, I don't see the version
information either, so this may not
be a problem, but I don't like it. Maybe there is some rule about this I
don't know about.
How have you tested mtx? The web site for mtx has some dubious comments on
whether mtx programs work in all levels of Solaris or all devices that might be
connected.
Steve Christensen
> Hi all
>
> Please help code review the inclusion of mtx-1.3.11
> into the sfw
> consolidation. It is a media changer controller
> software.
>
> The webrev is at:
> http://cr.opensolaris.org/~chrisliu/MTX
>
> Thanks in advance for your comments,
> Chris
This message posted from opensolaris.org
