Stefan, Here are my comments from my quickish skip through, see below ....
Stefan Teleman wrote: > http://cr.opensolaris.org/~steleman/6674044-6674042/ ==== Start of Comments === 1. usr/src/Targetdirs Keep it in alphabetical order 2. usr/src/lib/gnump/METADATA & usr/src/lib/mpfr/METADATA Add missing fields see ... http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines Remove the comment lines at the top 3. usr/src/lib/gnump/Makefile.sfw Change "env " to "env - " (4 places) Extract the 'VER=' from the METADATA file Change ... 176 ./configure --prefix=$(PREFIX) \ 177 --includedir=$(PREFIX)/include/gmp \ etc. and ... 203 ./configure --prefix=$(PREFIX) \ 204 --bindir=$(PREFIX)/bin/$(MACH64) \ to use ... CONFIGURE_OPTIONS += .... CONFIGURE_OPTIONS += .... ... ... ./configure $(CONFIGURE_OPTIONS) and .. CONFIGURE_OPTIONS64 += $(CONFIGURE_OPTIONS) CONFIGURE_OPTIONS64 += ..... ... ... ./configure $(CONFIGURE_OPTIONS64) In the 'clean:' rule, combine lines 264-268 into a single invocation of 'rm -f .....' Change 'all:' rule to ... all: all32 all64 lint32 lint64 and delete 161 real-all: all32 all64 lint32 lint64 In the 'install:' why are you first stalling it into a temp dir and then moving it into the proto area (using install-sfw(-64)), instead of directly installing it into the proto area? 4. *.diff files I haven't looked at these - I assuming u have got those right; and the makefiles actually invoke all the patches. 5. usr/src/lib/gnump/install-sfw & usr/src/lib/gnump/install-sfw-64 Remove the 'write permission' bit on files in /usr. You could pass in 'VERS=' as an environment var from Makefile.sfw. Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a > $ set -o errexit # at the beginning and replace > ". > ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to > catch failures in the script and abort it at that > point, right now the script will just continue) Doesn't install-sfw-64 overwrite the *.pc file from install-sfw ? 6. man page Should you give this its own man page if there isn't one supplied with the source pkg? (I can't see that you have installed one). 7. usr/src/lib/mpfr/Makefile.sfw See comments (3) 8. usr/src/lib/mpfr/install-sfw & usr/src/lib/mpfr/install-sfw-64 See comments (5) 9. usr/src/pkgdefs/SUNWgnu-gmp/Makefile & usr/src/pkgdefs/SUNWgnu-mpfr/Makefile Copyright year ? 10. usr/src/pkgdefs/SUNWgnu-gmp/depend & usr/src/pkgdefs/SUNWgnu-mpfr/depend Move 'Copyright' lines to after the 'CDDL HEADER END' header. 11. usr/src/pkgdefs/SUNWgnu-gmp/prototype_com & usr/src/pkgdefs/SUNWgnu-gmp/prototype_i386 & usr/src/pkgdefs/SUNWgnu-gmp/prototype_sparc 'write permissions' see (5) 12. usr/src/pkgdefs/SUNWgnu-mpfr/prototype_com & usr/src/pkgdefs/SUNWgnu-mpfr/prototype_i386 & usr/src/pkgdefs/SUNWgnu-mpfr/prototype_sparc 'write permissions' see (5) ==== End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
