Quanhong, See below for my comments from my *very* quick skip through ...
Paul wang quanhong wrote: > > I am porting open source tree which is a recursive directory listing > program that > produces a depth indented listing of files. Could you please help me to > review that? You can find webrev at: > http://cr.opensolaris.org/~xiangshu/tree/ > > BTW, since this package is related to two license(GPL and LGPL), so please > take more attention to the copyright file which I don't know how to > organize the > contents. === Start of Comments === 1. usr/src/cmd/tree/METADATA Add missing fields, see .. http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. usr/src/cmd/tree/Makefile.sfw You might want to put 'env - ' in front of the make, so it doesn't pick up random environment variables. 3. usr/src/cmd/tree/install-sfw You might want to put '#!/usr/bin/ksh93' (or bash) at the top of the script. 4. usr/src/pkgdefs/SUNWtree/copyright I'll let someone at Sun who know what it should be like looks at this, but ... Why has it got reference to the the following in it ... "This file is part of the libiberty library." ? 5. everything else looks okay to me === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
