Hi, See below for my comments ...
Paul Zhang Xiao Ping wrote: > > I am porting 'conflict' to opensolaris, which is a tool display conflicting > files in $PATH. > > Please kindly help review it. > http://cr.opensolaris.org/~yuntian/conflict/ === Start of Comments === 1. usr/src/cmd/conflict/METADATA Adding missing fields, see .. http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines 2. usr/src/cmd/conflict/Makefile.sfw Change 'env ' to 'env - ' Add 'env - ' in front of the 'make', etc., so it doesn't pick-up any random env variable. 3. usr/src/cmd/conflict/install-sfw Roland Mainz wrote: > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* and > add a $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the idea is to catch > failures in the script and abort it at that point, > right now the script will just continue) Maybe add 'exit 0' at the end 4. usr/src/pkgdefs/SUNWconflict/Makefile You have your own 'depend file so remove the line .. 29 DATAFILES= depend 5. usr/src/pkgdefs/SUNWconflict/copyright I'm no expert but is the content of this okay? Check within Sun. 6. usr/src/pkgdefs/SUNWconflict/depend Move the 'Copyright' lines to after the 'CDDL HEADER END' header This looks like the default 'depend' file; have you checked you have no other dependencies with the dependency checker script? If there are no others then remove this file and leave the 'DATAFILES= depend' in SUNWconflict/Makefile so it used the default file. 7. usr/src/pkgdefs/SUNWconflict/pkginfo.tmpl Maybe change the DESC= line to something like ... DESC="conflict - displays conflicting filenames in your execution path (6.0)" 8. usr/src/pkgdefs/SUNWconflict/prototype_sparc Cosmetic: Comment line ... 45 # List files which are I386 specific here "I386 specific" ??? === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
