Hi Nils,
today my colleagues Milan and Petr went through all changes and the have to had
following comments:
-------------------
1) Makefile.master
You added variables which you are not use. Because they are not used and never
will (/usr/sfw is obsolete), you should remove them.
We discussed also Portion copyright here in this file. We know that by process
it is your right to have it here, but it seems to us a too little change :-)
similar to targetdir file or like prototype_com. We prefer to do not put it
here, but it is up to you.
2) Targetdirs
Targetdirs is never ending story. Nobody knows if all directory have to be there
or not. By our discussion and what I remember, there should be only directories
which are not created automatically. Personally I think there should be only
directories which are not created by sfw gate like /var /usr and so on.
Please, remove all modifications here. They are useless.
3) METADATA
Please, remove # comments lines st the beginning.
4) remove unset PROFILE
5) please, remove FIXME from install.sfw or fix it :-)
I hope it will be fixed in 8.4 integration.
6) libpqxx/Makefile.sfw
libpqxx is not possible to make separately. It is annoying. We made conclusion
that Makefile.sfw should be "makeable". Probably best way how to do it is to
include some file which will contains path settings.
7) psqlrc issue
After long and hot discussion we made a decision to do not accept this change
for 8.3 at all. The reason is that it change behavior and there is no easy and
safe way how to implemented and does not break current installations.
It will be fixed in 8.4.
With regards Zdenek
PS: I will be on vacation next two weeks
