Here are some comments.
-Norm
usr/src/cmd/subversion/Makefile.sfw
* remove line 35
* remove a ".WAIT" from line 36
* put lines 41, 60-61. 97-98, 134-135 back from the original (this
appears to have been a mismerge and Mike will be unhappy if you
undo his fix :-( )
* remove the SWIG related contents from lines 171-185, 189
usr/src/cmd/subversion/swig*
* remove (use "wx rm ..." to do this)
usr/src/cmd/swig/Makefile.sfw
* line 33, why are you overriding "--with-swiglibdir" ? Is the
default value somehow broken?
* line 38, make sure that you are linking against the proto area,
make sure you add --norunpath and check if you need the standard
C++ libraries.
* lines 38-41, add CFLAGS="$(CFLAGS)" to the environment.
* line 45, remove
* lines 48-52, remove
* lines 56-57, add "INSTALL=$(INSTALL_PROTO)" and MANSCRIPT to your
environment
* lines 59-60, remove and use proto-fix to get the perms right on
the proto area (see a2ps, hpijs, cups, or other component for an
example)
usr/src/cmd/swig/install-swig
* incorporate the swig.1 manpage install into Makefile.sfw (and
anything else that "cd $VER; make install" didn't cover) and
remove this. It may not be necessary.
usr/src/pkgdefs/Makefile
* put the changes on lines 283, 285-295 back (mismerge, same as above)
usr/src/pkgdefs/SUNWswig/Makefile
usr/src/pkgdefs/SUNWswig/depend
* If you only have the "standard" dependencies, use DATAFILE in the
Makefile and don't deliver your own depend file.
Bruce Rothermal wrote:
> Could someone please review swig changes. Changed subversion Makefile to
> use new swig.
>
> http://cr.opensolaris.org/~bruce_r/swig/
>
>
