Frank, See comments below from my quick skip through review ...
Paul Frank Jennings wrote: > Requesting a code review of doxygen (Source Code Documentation Tool) for > integration into SFW consolidation. > > The webrev is at http://cr.opensolaris.org/~frankj/doxygen/ > === Start of Comments ==== 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile I don't see changes to these in your webrev. They should have changed to add your new stuff 2. usr/src/cmd/doxygen/Makefile.sfw Maybe you should explicitly add '--prefix=...' to your configure options (eg. as predefined in Makefile.master. Where is the oxygen1.patch patch applied ? 3. usr/src/cmd/doxygen/install-doxygen Copyright year is wrong 4. usr/src/pkgdefs/SUNWdoxygen/depend This looks like the default set of depends, if it is remove this 'depend' file and add DATAFILES= depend to your SUNWdoxygen/Makefile Have you checked you don't have any other dependencies by running the dependency checker script? 5. usr/src/pkgdefs/SUNWdoxygen/pkginfo.tmpl Some people add the pkg version on the DESC= line, but other don't (so feel free to ignore this comment. Also sometimes the DESC= line has the pkg name at the start, eg "doxygen - Source Code Documentation Tool" 6. usr/src/pkgdefs/SUNWdoxygen/prototype_com Copyright year is wrong 7. usr/src/pkgdefs/SUNWdoxygen/prototype_i386 This normally has the SUNW package name in comments (as in your prototype_sparc) - not that it really matters. === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
