Petr, See my comments from my quick skip through below ...
Paul Petr Slechta wrote: > > my task is to integrate Grails web framework (http://grails.org/) into > OpenSolaris 2008.11. > > I would like to ask you to review my code: > http://cr.opensolaris.org/~pslechta/grails/ === Start of Comments === 1. usr/src/cmd/grails/METADATA Add the URL of the place you got the source code from 2. usr/src/cmd/grails/install-grails The directories created by the mkdirs should be in Targetdirs. Why are you not doing the file copies/chmod (cp ...) using the '_install ? ...' function? Do any of the files copied during the directory copy need their permissions corrected afterwards? Roland Mainz wrote: > Please use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* > and add a > $ set -o xtrace # at the beginning and replace ". > ${SRC}/tools/install.subr" with "source ${SRC}/tools/install.subr" > (the idea is to catch failures in the script and abort it at that > point, right now the script will just continue) 3. usr/src/pkgdefs/SUNWgrails/depend Move Copyright lines down to after the "CDDL HEADER END" header and change copyright year 4. usr/src/pkgdefs/SUNWgrails/Makefile You don't need the null DATAFILES= 5. usr/src/pkgdefs/SUNWgrails/prototype_i386 & usr/src/pkgdefs/SUNWgrails/prototype_sparc Copyright year is wrong === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
