This is a follow up to the initial code review for the
GNU emacs integration project:
http://www.opensolaris.org/jive/thread.jspa?threadID=68215&tstart=15
A revised webrev is available at
http://cr.opensolaris.org/~alib/emacs/
It incorporates the previous comments I received, in particular:
- Eliminated the dynamic generation of the install-sfw
script in favor of checking in a static copy. Although
the dynamic generation worked fine, and was convenient for
me, it introduces a special case into the SFW consolidation.
- Eliminated the one-off copy of isaexec
- Eliminated the use of a static copy of libXaw
It also adds the GTK version of emacs, as SUNWgnu-emacs-gtk.
I'd like to thank Rich Lowe, Erwann Ch?ned?, and John Martin for
their help with this. We flushed out 2 bugs (one in the gnome nimbus
theme, and one in glib) to get there. It would not have happened
without the right people stepping up, and I appreciate it.
Thanks...
- Ali