Petr, Here are a couple of very minor comments, see below. Everything else looks good to me ...
Paul Petr Slechta wrote: > Hello, > > this is the second round of code review for project "Integrate Grails > web framework (http://grails.org) into OpenSolaris 2008.11". > > I incorporated feedback from Petr Sumbera, Paul Cunningham, and Roland > Mainz. Many thanks for the feedback! > > I would like to ask my reviewers and anybody who is interested to review > the code one more time: http://cr.opensolaris.org/~pslechta/grails2/ > === Start of Comments ==== 1. usr/src/cmd/grails/METADATA Most of the recent pkg integrations use 'URL: ...' to point at where the source code came from. 2. usr/src/pkgdefs/SUNWgrails/prototype_com Just an observation comment really ... The stuff in usr/grails/1.0.3/src I guess is source of the pkg so do you have to deliver this as part of the binary pkg? === End of Comments ====== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
