Christopher Mi wrote: > Please help review this webrev. > > URL: > http://cr.opensolaris.org/~mishuang/gnu-gperf/
2min race through http://cr.opensolaris.org/~mishuang/gnu-gperf/sfwnv.patch (patch code is quoted with "> "): > --- /dev/null Tue Apr 8 16:02:02 2008 > +++ new/usr/src/cmd/gnu-gperf/Makefile.sfw Tue Apr 8 16:02:02 2008 > @@ -0,0 +1,62 @@ [snip] > +VER=gperf-3.0.3 > + > +all: $(VER)/config.status > + (cd $(VER); env \ > + CC=$(CC) \ > + "CFLAGS=$(CFLAGS)" \ Please add "-xstrconst" here... ... BTW: Does "configure" add "-O" (= enable optimizer) when calling the compiler ? If not please add "-xO3" to CFLAGS ... > + LD_OPTIONS="-M $(SRC)/cmd/mapfile_noexstk" \ > + MAKE=$(CCSMAKE) \ > + $(MAKE)) > + @find . -name core -exec rm -f {} \; Why do you expect "core" files here (if something crashes the build should abort and not ignore such issues) ? ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
