Paul, See my inline comments.
Thanks very much for your review. - Simon Paul Cunningham : > Hi, > > Mainly looks good to me, just few minor comments ... > > Paul > > Ling-Jun Simon Wang wrote: >> <a href=http://cr.opensolaris.org/~lw202042/smartmontools/>code >> review for smartmontools</a> >> > > ====== Start of Comments ================ > > 1. usr/src/pkgdefs/Makefile > You seem to have removed some apache stuff, did u mean to? > Actually I didn't remove any stuff here. Instead, I need a bringover and I did it. > 2. usr/src/cmd/smartmontools/smartmontools.xml.in + > usr/src/pkgdefs/SUNWgnu-smartmontools/depend > You might want to move the copyright lines to after the > "CDDL HEADER END" > Yes. I did it. > 3. usr/src/pkgdefs/SUNWgnu-smartmontools > You don't seem to have included the Makefile in the webrev > Yes. I include it now. > 4. usr/src/pkgdefs/SUNWgnu-smartmontools/pkginfo.tmpl > You might want to remove the package version from the > 'DESC=' line. > Yes, I removed it. > 5. usr/src/pkgdefs/SUNWgnu-smartmontools/prototype_com > Should the 'etc' stuff be in a root package? > It should be in the root package. > 6. usr/src/pkgdefs/SUNWgnu-smartmontools/prototype_sparc + > usr/src/pkgdefs/SUNWgnu-smartmontools/prototype_i386 > name wrong in file - # SFWgnu ???? > Yes, a typo. I corrected it. > ====== End of Comments ================== >
