Lin Guo wrote:
>
> I have changed the code according to your comment. The changes are
> within two files, could you please help check them.
> The latest webrev has been uploaded.
Yes, these look good to me
paul
>
> ==========================
> #diff Targetdirs.old Targetdirs
> 25c25
> < #pragma ident "@(#)Targetdirs.old 1.111 08/04/22 SMI"
> ---
> > #pragma ident "@(#)Targetdirs 1.111 08/04/25 SMI"
> 1188c1188,1189
> < /usr/postgres/8.3/lib/$(MACH64)
> ---
> > /usr/postgres/8.3/lib/$(MACH64) \
> > /usr/lib/tcl8.4/tls1.6/$(MACH64)
> 1323c1324,1325
> < /usr/postgres/8.3/lib/64
> ---
> > /usr/postgres/8.3/lib/64 \
> > /usr/lib/tcl8.4/tls1.6/64
> 1382a1385
> > $(ROOT)/usr/lib/tcl8.4/tls1.6/64:= LINKDEST=$(MACH64)
>
> #diff install-sfw-64.old install-sfw-64
> 26c26
> < # ident "@(#)install-sfw-64 1.1 08/04/22 SMI"
> ---
> > # ident "@(#)install-sfw-64 1.1 08/04/25 SMI"
> 29,30c29
> < TLSDIR=${ROOT}/usr/lib/tcl8.4/tls1.6
> < TLSDIR64=${TLSDIR}/${MACH64}
> ---
> > TLSDIR64=${ROOT}/usr/lib/tcl8.4/tls1.6/${MACH64}
> 34,35d32
> < mkdir -p ${TLSDIR64}
> <
> 39d35
> < _install L ${MACH64} ${TLSDIR}/64 777
>
>
> Paul Cunningham wrote:
>> Looks okay in my quick look.
>>
>> You may want to move the 'mkdir' dir out of 'install-sfw-64' into
>> 'Targetdirs'
>>
>> Paul
>>
>> Lin Guo wrote:
>>> Hi all,
>>>
>>> Please help code review the inclusion of tcltls 1.6 into the sfw
>>> consolidation.
>>>
>>> The webrev is at:
>>> http://cr.opensolaris.org/~linguo/sfw_tcltls/
>>>
>>> Thanks in advance for your comments,
>>> Lin
--
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Computer Products
