Looks okay to me Though you may want to align the path-bit added into Makefile.master with the other stuff in it
paul Amanda Waite wrote: > Hi there, > > New WebRev including most of the requested changes is at > http://cr.opensolaris.org/~tekgrrl/lighttpd14-3/ > > I've not made changes to remove the MySQL dependency other than to > remove it from the SUNWlighttpd14u depend file. I'm waiting to hear back > about the need for an additional MySQL module package before proceeding > with that. > > Please review the changes and let me have your comments. > > Thanks > > Amanda > > > > Jyri Virkki wrote: >> Amanda Waite wrote: >> >>> Kindly review the updated WebRev for the Lighttpd integration at >>> http://cr.opensolaris.org/~tekgrrl/lighttpd14-2/ >>> >> *** usr/src/cmd/lighttpd14/Makefile.sfw >> - It's building against "/usr/mysql" which is the obsolete MySQL4 which >> AFAIK is going away any moment now. It should be using MySQL5 instead. >> - Why does it need "LD_LIBRARY_PATH=/opt/SUNWspro/lib", that seems odd? >> - I assume "INSTALL=/usr/bin/ginstall" is because it fails with the >> Solaris install? You should probably set a common define in >> usr/src/Makefile.master for ginstall as is done for most other things >> and then use that here. >> >> *** usr/src/cmd/lighttpd14/Solaris/index.html >> - Please don't deliver a default index.html file. Unfortunately this isn't >> set up yet (and unclear when it will be) but the intent is to move these >> default index files to a distro-specific package so they can carry the >> name/logo/etc of the distro. Delivering the index.html file now and >> later having to make this package not be its owner is more hassle >> which you could avoid. >> >> *** usr/src/cmd/lighttpd14/Solaris/ssl.conf >> - Does this create any problem given the out-of-the-box setup doesn't have >> SSL set up yet? >> >> *** usr/src/cmd/lighttpd14/patches/lighttpd-nodelay.patch >> - How are you tracking the adoption of the patch upstream? Is there a >> bug filed? There isn't a standard way in sfw for this but I'd like to >> see some documented tracking of these patches. Maybe include a comment in >> Makefile.sfw near the line where the patch is applied or have a separate >> text doc with pointers to the upstreams bug(s). >> >> *** usr/src/pkgdefs/SUNWlighttpd14r/prototype_com >> - The editable config files need some action (almost certainly 'renamenew') >> IIRC my verification script catches this so please run it on your >> workspace. >> - The contents of docroot are definitely also editable by the user or a >> web server isn't much use ;-) Although given earlier comments these files >> probably go away. >> >> *** usr/src/pkgdefs/SUNWlighttpd14u/depend >> - Is it necessary to force all lighttpd users to install MySQL? Would it >> be possible to factor out the dependency as was done in PHP? >> - One of the config files earlier (fcgi-php.conf) references PHP but it's >> not a dependency. Should it be (or factored out)? Or are those conf files >> only examples that don't necessarily get used (in which case I'd at least >> record the dependency in comments in the sample config)? >> >> >> > > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
