Hi Paul, Thanks very much for your quick response. I've already updated the webrev based on your comments. Please help review if possible. And also please check below for what's in the updated webrev and some comments.
Regards, Bill Paul Cunningham ???: > Bill, > > Here are a few comments from my quick skip through, see below ... > > Paul > > Yan Xue Yang wrote: > >> Hi Folks, >> >> Please help review the fix of CR 6689922. Any comments are welcome. >> Thanks. >> >> Webrev is at: >> >> http://cr.opensolaris.org/~billyan/unison/ >> >> CR synopsis: >> >> 6689922 unison 2.27.57 to be included into SFW consolidation >> >> PSARC case: >> >> http://opensolaris.org/os/community/arc/caselog/2008/212/ > > > === Start of comment ==== > > 1. usr/src/cmd/unison/METADATA > Doesn't have a 'PACKAGE:' field. > Are the other field names supposed to be in upper case? It's done > > 2. usr/src/cmd/unison/Makefile.sfw > Should the ocaml stuff be delivered as a separate package > builds (maybe)? > You seem to be building and installing parts of this in the > configure stage (so again split into separate pkgs maybe) We'll putback the source code of unison(unison-2.27.57.tar.gz), lablgtk(lablgtk-2.10.1.tar.gz) and ocaml(ocaml-3.09.2.tar.gz) to sfwnv gate. Ocaml is for the CAML compiler, and lablgtk provides the libraries which will be statically linked by unison. Lablgtk and ocaml will be only used during the compilation. Finally, there will be one package SUNWunison generated. And one file unsion(executable) and one file(unison.1) for man page are in the SUNWunison package. > > 3. usr/src/cmd/unison/install-unison > The Copyright' year is wrong > There are unused path defines in here (remove) It's done > > 4. usr/src/cmd/unison/unison.1 > Could this have been patched from the file in the tarball? As there is no man page in the tarball, the unison.1 man page is newly created. > > 5. usr/src/pkgdefs/SUNWunison > Does the package need a 'depend' file or does it need to use > the default depend? There is no dependency, so I removed the depend file. > > 6. usr/src/pkgdefs/SUNWunison/prototype_i386 + > usr/src/pkgdefs/SUNWunison/prototype_sparc > Move copyright line to after 'CDDL HEADER END'. > It is also not complete (2 lines) It's done > > 7. usr/src/pkgdefs/SUNWunison/prototype_com > Are there any other bits that need to be packaged (or is the > ocaml libs hard linked into unison)? Please check the comments in item 2. > > === End of Comments ===== >
