* Dermot McCluskey <dermot.mccluskey at sun.com> [2007-05-01 04:25]: > Some comments in addition to David's: > > 1. usr/src/cmd/coreutils/Makefile.sfw & usr/src/cmd/which/Makefile.sfw > - these lines can also be removed if you are not generating source pkgs: > $(ROOTEXFILES) := FILEMODE= 0555 > > $(ROOTSRC)/%: $(VER)/% > $(INS.file) Fixed.
> 2. usr/src/cmd/coreutils/install-sfw & usr/src/cmd/which/install-sfw > - why the "mkdir" commands? if there dirs are listed in usr/src/Targetdirs > and you have done "make rootdirs", you shouldn't need these. Fixed. > - also, why the "chown"s? Isn't this specified in prototype_com? Removed in favour of _install use. > 3. usr/src/cmd/coreutils/install-sfw & usr/src/cmd/which/install-sfw > - what are you doing about usr/share/info/dir? It looks like you're not > adding entries for the new info docs and assuming the infodir SMF service > will be approved and introduced to take care of this later. Is that correct? Yes, that's my intent. - Stephen -- sch at sun.com http://blogs.sun.com/sch/
