opensolaris.org is not a read only website. If the code needs to be
fixed, FIX IT and get the fixed tarball published on opensolaris.org
instead of taking the tarball as is and patching it. You are working
with the TIPC project people right? Can't they incorporate these
changes into a new version of the code distributed from their project page
that you then integrate into SFW?
I am not arguing against the changes, just that you're making them via
patches to the SFW gate and leaving the project publishing different versions.
In other projects, we call this "integrating fixes upstream", and that
can sometimes take work when dealing with external open source projects,
but is still highly recommended to make it easier to update to new versions
without having to recreate a bunch of patches against the new version.
But in this case, since upstream is opensolaris.org, it should go from
highly recommended to almost required - if we can't work with ourselves,
who can we work with? Why force yourself to do so much more work?
-Alan Coopersmith- alan.coopersmith at sun.com
Sun Microsystems, Inc. - X Window System Engineering
Vivek Titarmare wrote:
> Hi Alan,
>
> I did not get you completely.
> If I take the code directly from opensolaris, the issues are that it gets
> installed in /opt/SUNWtipc and as per the standards we have to install it in
> /usr as a parent folder. Also the header files which are getting extracted
> and being used are in /usr/solaris/include folder which was also creating a
> problem. For changing the locations to almost all the files, I have to change
> the code and generate patches. Every file is changing in this case.
>
> Pl. suggest, If I am going in the wrong direction.
>
> Thanks,
> ~Vivek R. Titarmare
>
> -----Original Message-----
> From: Alan.Coopersmith at Sun.COM [mailto:Alan.Coopersmith at Sun.COM]
> Sent: Friday, May 01, 2009 1:31 AM
> To: Vivek Titarmare
> Cc: sfwnv-discuss at opensolaris.org
> Subject: Re: [sfwnv-discuss] Request code review for "tipc"
>
> The question wasn't "Why are you making changes?" but "Why are you making
> changes by applying patches to a tarball that comes from opensolaris.org
> instead of just updating the tarball?" BTW, just because it's on
> opensolaris.org doesn't make it part of OpenSolaris already - it's your
> work that's making it part of the OpenSolaris distro instead of just a
> project under development.
>
> -Alan Coopersmith- alan.coopersmith at sun.com
> Sun Microsystems, Inc. - X Window System Engineering
>
> Vivek Titarmare wrote:
>> Hi Alan,
>>
>> We have to apply patches, just because the source code has paths which are
>> /usr/solaris/include/.. for header files and some paths are /opt/SUNWtipc/...
>> These paths were not approved in the ARC cases which I had submitted.
>> Changing the code or creating patches was required to match the requirements.
>> Also SUNWtipc is a part of Opensolaris already with the same tree structure
>> (/usr/solaris/...,/opt/SUNWtipc/..., etc). For us to port in Nevada we need
>> to follow the standards for installation and this needs a change in almost
>> all the files in tipc.
>>
>> Pl. suggest.
>>
>> Thanks,
>> ~Vivek R. Titarmare
>>
>>
>>
>> -----Original Message-----
>> From: Alan.Coopersmith at Sun.COM [mailto:Alan.Coopersmith at Sun.COM]
>> Sent: Thursday, April 30, 2009 4:05 AM
>> To: Vivek Titarmare
>> Cc: sfwnv-discuss at opensolaris.org
>> Subject: Re: [sfwnv-discuss] Request code review for "tipc"
>>
>> Vivek Titarmare wrote:
>>> I have posted a webrev for package "tipc" which I am porting to Neveda
>>> and would like to request a code review. Please see below link
>>>
>>> http://cr.opensolaris.org/~vivekrt/6833850-tipc/
>> Why are you applying patches to tarballs downloaded from opensolaris.org
>> instead of just having the opensolaris.org tarball updated?
>>
>
>
