Paul Cunningham wrote: > Petr, > > This mainly looks okay to me, just a couple of comments below .. > > Paul > > Petr Sumbera wrote: >> >> can somebody please look at my changes? >> >> Webrev: >> http://cr.opensolaris.org/~xsumbe00/6835864-gtar-1.22/ >> >> Note: tar-mv.diff is not needed since GNU tar 1.21. > > 1. usr/src/cmd/gtar/Makefile.sfw > [I may have got this wrong, but ...] > You are using './configure $(CONFIGURE_OPTIONS)' but doesn't > that give a the default --prefix of '/usr', where as I think > you want '/usr/gnu'. Probably just requires adding before > line 36 ... > CONFIGURE_OPTIONS = --prefix=$(CFGGNU) > CONFIGURE_OPTIONS += --mandir=$(CFGGNUMAN)
I don't want to install into /usr/gnu/. I want to install "gtar" into /usr/bin. That's how it is to day and how it was approved by ARC case. I'm doing just version upgrade. No other changes... > ie. isn't it supposed to install it in /usr/gnu and then > add the symbolic link for /usr/bin/gtar, and > /usr/sfw/bin/gtar, to /usr/gnu/bin/tar See above. > 2. usr/src/pkgdefs/SUNWgtar/prototype_com > Maybe the tar.mo file permissions should have the write bit > removed? Why not. Fixed. > 3. depend > I assume this hasn't changed the dependencies Right, no changes in dependencies. Webrev updated. Thanks! Petr
