Helen, Mainly looks good to me, see below for a few comments ...
Paul Helen Chao wrote: > > There's a newer version of the tool came out couple weeks > ago; so I picked up this newer version for the porting, > and created couple patches for OpenSolaris. > > Please take another look of the webrev: > http://cr.opensolaris.org/~helenc/nfswatch/webrev2/ > > Only the top 6 files have been changed and the new tar file > (of version 4.99.10, instead of 4.99.9). Other files have > no change. 1. usr/src/pkgdefs/SUNWnfswatch/pkginfo.tmpl Version is wrong on the DESC= line 2. usr/src/pkgdefs/SUNWnfswatch/depend Are there any other dependencies? Have you used dependency checker script to check? 3. usr/src/cmd/nfswatch/Makefile.sfw You are using gcc to build this will it build with Sun's compilers (maybe with a few patches) ? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
