Vivek, Vivek Titarmare wrote: > > [On behalf of Dipesh, I am replying. Dipesh is on leave for this week] > > The fix is only for Bug 6836954: Do you want us to change the copyright year > in this case.
I personally think the Copyright year should be changed. > And also the format of the apache-ant-1.7.1? This will need changing a some point - the changes that Norm is doing may already cover it. So I guess it's up to you if you change it or not. > > This fix is actually for creating ant-antlr.jar file, just by adding the > class path ant would use the classpath to generate the jar file which is > required by antlr 3.0 and stringtemplate packages. Paul > > -----Original Message----- > From: sfwnv-discuss-bounces at opensolaris.org > [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Paul Cunningham > Sent: Friday, May 08, 2009 6:35 PM > To: Dipesh Hadye > Cc: Charles.Binford at Sun.COM; sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "Bug 6836954 - ant " > > Dipesh, > > Comments below .. > > Paul > > Dipesh Hadye wrote: >> I have posted a webrev for "*Bug 6836954 : ant is missing several jar >> files in build 105 <http://monaco.sfbay.sun.com/detail.jsf?cr=6836954>" >> * and would like to request a code review . >> >> The bug addresses several missing jars, I have done the changes to >> include *ant-antlr.jar* which is required for *antlr *and > *stringtemplate*. >> Please see below link >> http://cr.opensolaris.org/~vivekrt/6836954-ant-bug/ > http://bugs.opensolaris.org/view_bug.do?bug_id=6836954 > > How does this change to 'ant/Makefile.sfw' fix this bug, ie. missing jar > files? > > Also you need to do ... > > 1. change the Copyright year > 23 # Copyright 2008 Sun Microsystems .... > > 2. you should probably change the line .. > 31 ANT=apache-ant-1.7.1 > so it extracts the name and version from the METADATA > (Note, METADATA file format is change as per heads-up, so > as in "http://wikis.sun.com/display/SFWNotes/METADATA"; > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
