Hao, See comments below ..
Paul wang hao wrote: > The webrev page is here: http://cr.opensolaris.org/~snowsky/webrev_2/ >> Hao Wang wrote: >>> The webrev page: >>> http://cr.opensolaris.org/~snowsky/webrev/ >> >> === Start of Comments ==== >> 1. usr/src/lib/libexosip2/METADATA This needs updating again so that it now conforms to Norm's heads-up of last week, see ... "http://wikis.sun.com/display/SFWNotes/METADATA"; & "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; You will probably need to resync your ws with the gate/clone to pick up those changes in the gate. 2. usr/src/lib/Makefile & usr/src/pkgdefs/Makefile Needs resyncing with the gate/clone, otherwise it looks as though you are changing other stuff! >> 3. Copyright year (maybe all your files) >> Change to this year. There are still wrong ones, they should be ... "# Copyright 2009 Sun Microsystems, Inc. All rights reserved." >> 4. usr/src/lib/libexosip2/Makefile.sfw Line ... 34 CONFIGURE_OPTIONS += '--prefix=/usr' I think you can delete this as the prefix is already defined in Makefile.master >> 6. usr/src/lib/libexosip2/install-sfw >> You should probably add this dir to Targetdirs ... >> 41 mkdir -p ${INCDIR}/eXosip2 You are still doing this ? Also is /usr/lib/eXosip2 in Targetdirs, if not I think it should be? 7. usr/src/lib/libexosip2/Makefile.sfw & usr/src/lib/libexosip2/install-sfw There is no sccs ident line in these files! >> 13. usr/src/pkgdefs/SUNWlibexosip2/prototype_com Don't install files in /usr with the write permission bit set -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
