Hi Paul, Again, on the behalf of Dipesh. I am updating the files and uploading the webrev. Updated files with the changes suggested.
http://cr.opensolaris.org/~vivekrt/drools Thanks, ~Vivek R. Titarmare -----Original Message----- From: [email protected] [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Paul Cunningham Sent: Wednesday, May 13, 2009 4:47 PM To: Dipesh Hadye Cc: Charles.Binford at Sun.COM; sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "drools" Dipesh, Mainly looks good to me, but see comments below ... Paul Dipesh Hadye wrote: > I have posted a webrev for package "drools" which I am porting to > OpenSolaris and would like to request a code review. > > Please see below link > http://cr.opensolaris.org/~vivekrt/drools/ > > Let me know if any updates are required in the package files. 1. usr/src/lib/drools/METADATA Needs updating to conform to ... "http://wikis.sun.com/display/SFWNotes/METADATA"; (You will probably have to resync with clone/gate to get it to build again) 2. usr/src/pkgdefs/SUNWdrools/prototype_com Line ... 2678 s none usr/share/lib/java/drools-core.jar=drools-core-4.0.7.ja should that be =drools-core-4.0.7.jar ? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit _______________________________________________ sfwnv-discuss mailing list sfwnv-discuss at opensolaris.org http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
