Srirama Sharma wrote: > Hi George, > > > George Vasick said the following on Wednesday 13 May 2009 09:01 PM: >> Sorry about that. I cloned my workspace into a new filesystem as a >> backup before upgrading my system and then updated the webrev from the >> child instead of the parent. It is corrected now. > > That's no problem. > > The webrev mainly looks good to me. > > Just a suggestion, you could change the putback comments to "<bug-id> > <synopsis>" format to have uniformity with other products in SFW.
Yes. I'll do that when I use the tool to collapse my changes into a single revision. Thanks, George > > Thanks, > Srirama > >> >> >> Thanks, >> George >> >> >> Srirama Sharma wrote: >>> Hi George, >>> >>> >>> George Vasick said the following on Tuesday 12 May 2009 01:55 AM: >>>> Hi, >>>> >>>> This is a resend of my code review request sent out last week. I >>>> really could use your help to review my changes for the upgrade of >>>> autoconf from 2.61 to 2.63: >>>> >>>> http://cr.opensolaris.org/~gvasick/6838600/ >>> >>> The webrev appears to be having partial changes. It has changes to >>> only one file SUNWaconf/prototype_com where in you are adding a new >>> file entry. >>> >>> It doesn't have any changes that you may want to do to METADATA, >>> Makefile.sfw, pkginfo.tmpl and also add new 2.63 tarball. Please check. >>> >>> Thanks, >>> Srirama
