Paul, Thank you for your comments, please in reply in line.
> Jason, > > Mainly looks good to me, but see below for a few comments ... > > Paul > > Jason Zhao wrote: > >> >> Here is the webrev: >> http://cr.opensolaris.org/~jxzhao/snort/ >> >> Please review it and tell me your comments. > > 1. usr/src/cmd/Makefile > & usr/src/pkgdefs/Makefile > These need resyncing with the clone/gate Done. > > 2. usr/src/cmd/snort/METADATA > Line ... > 7 SOURCE_DOWNLOAD: http://www.snort.org/dl/snort-2.8.4.tar.gz > the url doesn't work for me ! The link was changed to "http://www.snort.org/dl/snort-2.8.4.1.tar.gz";. The old link above was obsolete obviously. The snort website changes the download location often. :( > > 3. usr/src/cmd/snort/snortd > Where is the 'case' for 'restart' ? Sorry, it just supports "start" now, I have removed the "restart" from Usage. > > 4. usr/src/pkgdefs/SUNWsnortu/prototype_com > Do the symbolic link lines need the ' 0555 root bin' stuff? Thank you, it is obviously mistake. :) > > And maybe the symbolic link lines (s) should come after the file (f) > lines they are a symbolic link to ? Done. > > Is the stuff in this file relevant to solaris ? ... > 104 f none usr/share/doc/snort/README.WIN32 > > should you be delivering these files ? .... > 132 f none usr/share/doc/snort/TODO > 134 f none usr/share/doc/snort/WISHLIST The above files have been removed. The webrev has been updated. http://cr.opensolaris.org/~jxzhao/snort Thanks Jason
