looks okay to me p
Vivek Titarmare wrote: > Hi Paul, > > The Makefile is changed with the new list of packages are webrev is > uploaded. > > Thanks, > ~Vivek R. Titarmare > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Wednesday, May 27, 2009 6:09 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "ognl" > > Looks good to me, just a single cosmetic comment, see below ... > > Paul > > Vivek Titarmare wrote: >> I have posted a webrev for package "ognl" which I am porting to Nevada >> and would like to request a code review. Please see the link below >> >> http://cr.opensolaris.org/~vivekrt/6835988-ognl/ > > 1. usr/src/pkgdefs/Makefile > Add new item alphabetically > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
