Hi Paul, Done with all the changes and have uploaded the webrev. http://cr.opensolaris.org/~vivekrt/6835990-oro/
Let me know if I am missing any.. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Wednesday, May 27, 2009 6:23 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "oro" A few comments below ... paul Vivek Titarmare wrote: > I have posted a webrev for package "oro" which I am porting to Nevada > and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835990-oro/ 1. usr/src/lib/Makefile Why two "FRC:" rules? 2. usr/src/lib/oro/METADATA Version on the SOURCE_DOWNLOAD: line looks wrong And is that link (with .8) correct? - doesn't work for me 3. usr/src/lib/oro/install-sfw Lines ... 77 exit 0 78 c 444 what are these? 4. usr/src/lib/oro/sunman/oro.3 Line 34 (the description) .. does this have to be all on one very-looooooooong-line, could it be broken up across n lines ? 5. usr/src/pkgdefs/SUNWoro/copyright Are there any source owner copyright lines that can be added at the top here ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
