Vivek, A few comments below ...
Paul Vivek Titarmare wrote: > I have posted a webrev for package "backport-util-concurrent" which I am > porting to Nevada and would like to request a code review. Please see > the link below > > http://cr.opensolaris.org/~vivekrt/6835999-backport-util-concurrent/ 1. usr/src/lib/Makefile Lines ? .... 165 FRC: 166 ore 167 168 FRC: ??? 2. usr/src/lib/backport-util-concurrent/METADATA Again 'utility' on BUGTRAQ: line ? 3. usr/src/lib/backport-util-concurrent/Makefile.sfw Line ... 43 ANTCMD=/usr/bin/ant just a suggestion; you could put this into Makefile.master so you and other pkgs can use it from there (rather than defining it here). Line ... 58 gtar -xvzf $(TARBALL) maybe change 'gtar' to '$(GTAR)' 4. usr/src/pkgdefs/SUNWbackport-util-concurrent/copyright Line ... 16 License Details from the URL: do you need this ? Shouldn't it just say "CREATIVE COMMONS PUBLIC LICENSE (CCPL)" as a header to the text below it? Manually wrap the long-lines. Lines 91 to 128, do you need these? Lines 3 to 12, do you need these? Line 19, remove the 'space' chars at the start of the line. END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
