Thanks Paul. All the changes done. Webrev is uploaded at the same location.
Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, May 29, 2009 12:26 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "commons-pool" Vivek, Mainly looks good to me, just a couple of minor cosmetic comments .... Paul Vivek Titarmare wrote: > I have posted a webrev for package "commons-pool" which I am porting to > Nevada and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835996-commons-pool/ 1. usr/src/pkgdefs/Makefile Reorder alphabetically 2, usr/src/pkgdefs/SUNWcommons-pool/pkginfo.tmpl On the DESC= line, add spaces after each of the ')' brackets, eg. ".... aspects: 1) Easily ..." END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
