Hi Paul, Regarding point 2, concurrent was categorized as utility by the legal team. So this packages goes under utility.
Rest changes are done and the webrev would be uploaded in next 10 minutes. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Friday, May 29, 2009 12:56 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "concurrent" Vivek, See comments below ... Paul Vivek Titarmare wrote: > I have posted a webrev for package "concurrent" which I am porting to > Nevada and would like to request a code review. Please see the link below > > http://cr.opensolaris.org/~vivekrt/6835998-concurrent/ 1. usr/src/Targetdirs & usr/src/pkgdefs/Makefile Add items alphabetically 2. usr/src/lib/concurrent/METADATA Line .. 9 BUGTRAQ: solaris/utility/concurrent why is this 'utility' where as some of your other pkgs are 'java_classes' - shouldn't it be consistant across all your pkgs? 3. usr/src/pkgdefs/SUNWconcurrent/copyright You should probably add carriage-returns in here so that you don't have long lines END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit General Dynamics Itronix Europe Ltd. Pioneer House Chivers Way Histon, Cambridgeshire, UK, CB24 9NL Ph: +44 (0)1223 200648 FAX: +44 870 4324162 Email: paul.cunningham at tadpole.com This email message is for the sole use of the intended recipient(s) and may contain GDC4S confidential or privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not an intended recipient, please contact the sender by reply email and destroy all copies of the original message
