Looks good to me Paul
Vivek Titarmare wrote: > Hi Paul, > > Changes are done and updated the webrev at the same location. > > Thanks, > ~Vivek R. Titarmare > > > -----Original Message----- > From: Paul Cunningham [mailto:paul.cunningham at tadpole.com] > Sent: Thursday, May 28, 2009 8:34 PM > To: Vivek Titarmare > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "commons-codec" > > This looks good to me except for minor comment below ... > > Paul > > Vivek Titarmare wrote: >> I have posted a webrev for package "commons-codec" which I am porting to >> Nevada and would like to request a code review. Please see the link below >> >> >> >> http://cr.opensolaris.org/~vivekrt/6835991-commons-codec/ > > 1. usr/src/pkgdefs/SUNWcommons-codec/copyright > Typo on line ... > 2 opyright 2001-2004 The Apache Software Foundation. > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
