I'll take another look at it when you have fixed all the stuff I have replied to privately (to answer your queries).
paul Jan Forch wrote: > Hi folks, > thank you very much for comments. I fixed as many things as possible. > Some of RFE's needs additional comments. Please let me know. Have a nice > weekend ;-) > Jan Forch, Sun Microsystems > > Current webrev presentation is on: > http://cr.opensolaris.org/~jf222792/sfwnv_rc > > === Start of Comments === > > 1. usr/src/cmd/freeipmi/METADATA > Update as per "SFW Package writing guidelines" ... > "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; > FIXED > > 2. usr/src/pkgdefs/Makefile > & usr/src/cmd/Makefile > Resync with gate/clone > FIXED > > 3. usr/src/pkgdefs/SUNWfreeipmir/depend > & SUNWfreeipmir/Makefile > Use the default 'depend' rather than this in the root package > DO NOT UNDERSTAND MORE DETAILS PLEASE > > 4. SUNWfreeipmir/Makefile > & SUNWfreeipmiu/Makefile > where is these ? > FIXED > > 5. File Copyright year > Correct this in all relevant files > FIXED > > 6. Top of file layout > Fix this in all files as per ... > "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; > FIXED > > 7. usr/src/cmd/freeipmi/Makefile.sfw > Extract the VER= info from the METADATA - there are numerous > examples in gate now. > FIXED > > Lines ... > 61 MAKE=$(CCSMAKE) \ > 62 DESTDIR="$(ROOT)" \ > 63 INSTALL=/usr/bin/ginstall > you could put these before the '$(CCSMAKE) install', > and for lines 68-70. > FIXED > > Do you need to use 'protofix' to fix the permissions on > files installed with 'make install' ? (see comment 13) > DO NOT UNDERSTAND MORE DETAILS PLEASE > > Lines 84-91 and 95-103 ... > use the predefined '--prefix=' value from Makefile.master > ie, something like ... > CONFIGURE_OPTIONS += --with-dont-check-for-root > CONFIGURE_OPTIONS += --sysconfdir=/etc > etc. > .... > $(SHELL) ./configure $(CONFIGURE_OPTIONS) > FIXED > > 8. usr/src/cmd/freeipmi/install-sfw > Change as per ... > Roland Mainz wrote: > > use /usr/bin/ksh93 for install-sfw* and add a > > $ set -o errexit # at the beginning and replace > > ". ${SRC}/tools/install.subr" with > > "source ${SRC}/tools/install.subr" (the idea is to catch > > failures in the script and abort it at that point, > > right now the script will just continue) > NOT FOUND ANY PROJECT IN GATE WHICH USES ksh93 etc. > > Why don't you use the '_install' macro rather than ginstall? > FIXED > > Man pages: why not edit the man pages files and then install into > the proto area with '_install M ..) > WHAT IS DIFFERENCE BETWEEN THIS AND CURRENT SOLUTION? > > 9. usr/src/cmd/freeipmi/sunman-stability > Where is the stability stuff? > Add line for where to get source from on opensolaris.org? > WHAT EXACTLY SHOULD I ADD? > DO NOT SEE ANYTHING ADDITIONAL IN OTHERS PROJECTS > > 10. usr/src/pkgdefs/SUNWfreeipmir/pkginfo.tmpl > DESC= line, put pkg version at end of line, eg. > DESC="................... (0.7.7)" > FIXED > > 11. usr/src/pkgdefs/SUNWfreeipmir/prototype_com > & usr/src/pkgdefs/SUNWfreeipmiu/pkginfo.tmpl > Line ... > 53 f none etc/ipmi_monitoring_sensors.conf > does this file need to be preserved over SUNW pkg update? > (may be others) > YES > > Lines ... > ARCH="i386" > VERSION="11.11.0,REV=2009.04.03.13.50" > are wrong - this looks like the file has been > built - get .tmpl file from another package in the gate/clone > FIXED > > 12. usr/src/pkgdefs/SUNWfreeipmiu/depend > Again this looks like the default 'depend' - have > you checked you have no other dependencies with the > dependency checker script? > DO NOT UNDERSTAND MORE DETAILS PLEASE > WHERE TO FIND dependency checker script AND HOW TO USE IT? > > 13. usr/src/pkgdefs/SUNWfreeipmiu/prototype_com > Do not install files in /usr with the write permision > bit set. > EVEN FOR OWNER (ROOT)? WHICH FILES DID YOU MEAN (copy + paste from list > please)? > > 14. First can you resync your workspace with the clone and regenerate > the webrev (and repost). In both > usr/src/cmd/Makefile > usr/src/pkgdefs/Makefile > FIXED > > 15. > Also, some of your files appear to have been checked out when you > created the webrev, they have ident strings like: > #ident "%Z%%M% %I% %E% SMI" > Instead of like: > # ident "@(#)install.sfw 1.3 09/04/09 SMI" > FIXED -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
