Hi Paul, Paul Cunningham wrote: > Lukas, > > Looks good now, but see comment below .. > Thanks.
> Paul > > Lukas Rovensky wrote: >> >> thanks for thorough review. I added some comments below and updated >> the webrev at http://cr.opensolaris.org/~lukas/pwgen/ . Let me know, >> please, if you have any additional comments. > > ...cut ... > ... cut.... >>> 4. usr/src/pkgdefs/SUNWpwgen/depend > ... cut ... >> >>> This also looks like the default set of dependencies, have >>> you checked the pkg has no others with the gate's pkg >>> dependency checker script? If if has no others then delete >>> this and use the default depend. >>> >> Yep, I used the dependency checker script. I compared the >> depend for pwgen with the one at pkgdefs/common_file and they >> differ, so I left the depend file as it is. > > Personally I still think, as you have no specific extra dependencies > here you could use the default depend, eg. > delete your 'depend' files > + add 'DATAFILES = depend' into SUNWpwgen/Makefile > As for the depend file -- I followed your recommendation and used the default depend file. The webrev at http://cr.opensolaris.org/~lukas/pwgen/ is modified accordingly. Thanks, Lukas
