Hi, thank you all for looking at it! I have changed workspace with proposed changes from Lukas (METADATA), Pradhap (patch) and Paul (see bellow).
Webrev is updated: http://cr.opensolaris.org/~xsumbe00/6811116.slrn/ Paul Cunningham wrote: > Petr, > > This mainly looks good to me, couple of minor comments below .... > > Paul > > Petr Sumbera wrote: >> >> Can somebody please look at my integration work for slrn (USENET news >> reader - PSARC/2008/639)? >> >> http://cr.opensolaris.org/~xsumbe00/6811116.slrn/ > > 1. usr/src/cmd/Makefile > Keep the list in alphabetical order Done. > 2. usr/src/pkgdefs/SUNWslrn/copyright > Add src owner copyrights after the sun disclaimer, > see example in ... > "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; > Done. > 3. man pages slrn.1 & slrnpull.1 > Do you need to add the sunman stability stuff, as I > can't see where that is done This is done via setting in Makefile.sfw: INSTALL="$(INSTALL_PROTO)" MANSCRIPT="$(COMPONENT_TOP)/sunman-stability" It really works :-) Thanks, Petr
