Hi James, Now all the files are updated with CDDL header. Let me know if I am missing anything on the CDDL header info, or let me know if I am wrong somewhere in updating the info.
And yes, we have multiple versions of Antlr (2.7.7 and 3.0) and that is why I have registered 2 names SUNWantlr277 and SUNWantlr which would come soon for review. Also, the end user can use $ man antlr277and $ man antlr. However $ man antlr would give both package information. Pl. suggest, if we can have some other way to handle both the versions. Thanks & Best Regards, ~Vivek R. Titarmare -----Original Message----- From: James.Walker at Sun.COM [mailto:[email protected]] Sent: Wednesday, March 11, 2009 10:06 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "antlr277" Vivek Titarmare wrote: > Hi, > > As mentioned below almost all the points are updated and the new webrev is > uploaded. The url is http://cr.opensolaris.org/~vivekrt/antlr277. As as been mentioned multiple times. You need to clean up the CDDL headers in all files to match this: http://cr.opensolaris.org/~vivekrt/antlr277/usr/src/pkgdefs/Makefile.html Are you planning to have multiple versions of antlr in OpenSolaris at the same time? Why? If you don't need multiple versions then I would get rid of the 277 suffix. antlr277.3 If a user types: $ man antlr What do they get? What about "$ man antlr227" ? Cheers, Jim -- Jim Walker, http://blogs.sun.com/jwalker Sun Microsystems, Broomfield, Colorado
