Stefan, See below for my comments ...
Paul Stefan Teleman wrote: > http://cr.opensolaris.org/~steleman/6802445/ === Start of Comments === 1. usr/src/lib/unixodbc/METADATA Change so that it conforms to that in ... "http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines"; 2. usr/src/lib/unixodbc/METADATA & usr/src/lib/unixodbc/Makefile.in.2.diff & usr/src/lib/unixodbc/cursorlibrary.h.1.diff I don't thing these need the CDDL and Copyright header stuff 3. usr/src/lib/unixodbc/Makefile.sfw Extract the VER= info from the METADATA Do this !! ... Roland Mainz wrote: > use "env - ..." and not "env ..." in the Makefiles > to make sure "configure"&&"make" only see the env > variables they should really get (and not pick-up any > random env variable). > Use either $(SHELL) or /usr/bin/bash for "configure" > calls (so we know which one is used and "configure" > doesn't pick one itself). Use the predefined CONFIGURE_OPTIONS from Makefile.master rather than the inline --prefix=. Then append your other configure options to that outside the rule sections I don't think you need the .. 115 cd .. 139 cd .. Use the predefined /etc, /usr/ from Makefile.master in lines 110-113 and 134-137. There probably should be one for /var to! Move the 'make install' bits (lines 149 & 159) into the appropriate 'install*:' rules. Why are you doing the install twice, once with 'make install' and then with install-sfw? You just use the 'make install' directly into the proto area I think. Are these used ? if not delete them .. 37 SUFFIX_64_sparc = sparcv9 38 SUFFIX_64_i386 = amd64 4. usr/src/lib/unixodbc/install-sfw & usr/src/lib/unixodbc/install-sfw-64 Pass in VERS= info from the Makefile.sfw Do this !! .. Roland Mainz wrote: > use /usr/bin/ksh93 for install-sfw* and add a > $ set -o errexit # at the beginning and replace > ". ${SRC}/tools/install.subr" with > "source ${SRC}/tools/install.subr" (the > idea is to catch failures in the script and abort > it at that point, > right now the script will just continue) Don't install files into /usr with the write permission bits set (also see item (9) below) Cosmetic: Fix top of file so it conforms to that in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; ie. missing line-space 5. usr/src/pkgdefs/Makefile This needs resyncing with the gate otherwise it looks as though you are trying to change stuff you don't intend to. 6. CDDL HEADER and top of files (various files) Cosmetic: Fix top of files so it conforms to that in .. "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; (Mainly missing line-space after CDDL HEADER END) 7. usr/src/pkgdefs/SUNWunixodbc/copyright (and maybe usr/src/pkgdefs/SUNWunixodbcr/copyright) This probably needs the Sun disclaimer and src owner copyright lines added, see example in .. "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 8. usr/src/pkgdefs/SUNWunixodbc/depend Move Copyright lines to after the CDDL HEADER END header have you checked there are no other dependencies using the dependency checker script. 9. usr/src/pkgdefs/SUNWunixodbc/prototype_com & usr/src/pkgdefs/SUNWunixodbc/prototype_i386 Don't install files into /usr with the write permission bits set (also see item (4)) 10. usr/src/pkgdefs/SUNWunixodbc/prototype_i386 Is this line required ... 50 d none usr/bin/amd64 11. usr/src/pkgdefs/SUNWunixodbcr/pkginfo.tmpl On the DESC= line .. a) Change (root package) to just (root) b) I don't think you need the pkg version on this line in a root pkg (saves a bit of time next time it is updated) 12. SUNWunixodbcr The configure in Makefile.sfw defines options for /var, so should the root pkg put that dir in place ? === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
