Helen Chao wrote: > I am porting "nfswatch", an NFS server monitor to the SFW consolidation. > > Please help to code review my changes. The webrev is at: > http://cr.opensolaris.org/~helenc/nfswatch/ >
Here's some comments: Recheck your CDDL and copyright headers (ie. remove double blank spaces in some files). The headers should be similar to this file: http://cr.opensolaris.org/~helenc/nfswatch/usr/src/cmd/Makefile.html usr/src/cmd/nfswatch/METADATA - add the following line at the top: NAME: nfswatch - monitor an NFS server - add the following line after URL: SRC: <pointer to source code> - like what is included here: http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/METADATA.html You need to add a sunman-stability file and update your install-sfw file like is done here to append the stability and pkg name info to the man pages like is done here: The change from .8 to .1 man pages is correct. http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/install-sfw.html http://cr.opensolaris.org/~lxin/iperf/usr/src/cmd/iperf/sunman-stability.html usr/src/pkgdefs/SUNWnfswatch/Makefile - since the dependences in your depend file are the defaults, you can delete the depend file and add lines 31-32 like so: 29 include ../Makefile.com 30 31 DATAFILES= depend 32 33 .KEEP_STATE: - this assumes you have checked your dependences usr/src/pkgdefs/SUNWnfswatch/pkginfo.tmpl - should be... (no "v" required) 43 DESC="nfswatch - monitor an NFS server (4.99.9) Cheers, Jim
