Hi Paul,
  Yes, i have incorporated the new changes.
Pls do review it.
Location: http://cr.opensolaris.org/~an230044/dosbox/

Thanks,
Abhijit

On 03/31/09 18:30, Paul Cunningham wrote:
> Abhijit,
>
> This mainly look okay to me now, see below ...
>
> Paul
>
> Abhijit Nath wrote:
>>
>> Pls do review it Location: http://cr.opensolaris.org/~an230044/dosbox/
>
> 1. usr/src/cmd/Makefile
>     & usr/src/pkgdefs/Makefile
>    Needs resyncing with gate so it doesn't look as
>    though you are trying to delete other stuff
>
> 2. usr/src/cmd/meld/Makefile.sfw
>    Why is this here ?
>
> 3. Top of files (all)
>    Cosmetic: the tops of the files still do not
>    fully conform to those in ...
> "http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/prototypes/"; 
>
> ie. you have ...
>     # information: Portions Copyright [yyyy] [name of ...
>     #
>     # CDDL HEADER END
>     #
>     # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
> but it should be (missing bits at -> ) ...
>     # information: Portions Copyright [yyyy] [name of ...
>     #
>     # CDDL HEADER END
>     #
> ->
> ->  #
>     # Copyright 2009 Sun Microsystems, Inc.  All rights reserved.
>
>


Reply via email to