Paul, Thanks for the review, I'm fixing things, but have a couple of questions in line.
Paul Cunningham wrote on 06/02/09 08:44: > Bobbie, > > This mainly looks okay to me, see below for a few comments ... > > Paul > > Bobbie wrote: >> Requesting C-Team review for logilab-astng project >> >> webrev >> http://cr.opensolaris.org/~blong/logilab-astng/ > > please note that the following are only available internally to Sun on > the SWAN not externally ... > I have no idea how to do this. I'm a package porting neophyte and have followed (I thought) the directions others have provided. So if you can tell me how, I'll be delighted to make the change that will make it external. I've opened the permissions, but that is apparently not the correct answer. >> PTL Project 5474 >> http://sac.eng/projectlog/ptl/dashboard.php?UniqueID=5474 >> >> LSARC >> http://sac.sfbay/arc/LSARC/2009/299/ >> >> Check list table updated with logilab-astng details >> http://ostest.central.sun.com/wiki/index.php/Package_Porting_Tracking#SFW_C-Team_Checklists >> >> >> Please let me know if you need any additional information, or >> what I need to do next. > > 1. usr/src/Targetdirs > Line ... > 1462 that /usr/share/lib/java/javadoc/junit \ > why the 'that' ? no clue, I'll fix. > > 2. VERSION: 0.19.0 > Note the pkg's home page says that version 0.20.0 will > be released (maybe!) on 05JUNE, so you might want to > consider using that if it is released. I could, but it will likely not make 117. And since the current progress meter on the 0.20.0 still shows none, I'm inclined to think they might not make the 05June date. If it's available in time for the putback I could, but that would likely result in another round of reviews, wouldn't it? > > 3. usr/src/lib/logilab-astng/Makefile.sfw > Line ... > 39 gzip -dc $(TARBALL) | tar xmpf - > change 'tar' to '$(TAR)'. You also might want to think about > using the built in uncompress of the tarball rather than doing > it explicitly (personally I prefer it done explicitly though). > > Line ... > 46 chmod 444 $(PROTOMAN)/logilab-astng.3 > do you need this, as the following protofix should > also correct it I think ? I don't know what the protofix does, so I'll have to test it out and change it accordingly. > > 4. usr/src/pkgdefs/Makefile > This needs resyncing with the gate/clone so it doesn't look > as though you are changing other stuff. will do. > > END Will send an updated webrev when things are fixed.
