Alex, It's good for me.
Lizhong alex zhang wrote: > Thanks Lizhong for review. > A newer version of webrev at http://cr.opensolaris.org/~alz/bittorrent/ > Please have a look at it. > All the questions are resolved. > > Thanks > On Apr 16, 2009, at 4:23 PM, Lizhong Li wrote: > >> Alex, >> >> It looks fine, except these comments: >> >> 1. copyright >> >> Perhaps you should add the header of sun to it, like >> >> http://cr.opensolaris.org/~uniopen/mrtg/usr/src/pkgdefs/SUNWmrtg/copyright.html >> >> >> >> 2. depend >> >> Did you check it by 'make check_deps' ? >> >> 3. SUNWlibtorrent/prototype_com SUNWlibtorrent/prototype_i386 >> >> 1 # >> 2 # >> 3 # CDDL HEADER START >> >> and 43 # >> 44 # >> 45 # >> etc.. >> >> Line 1 should be deleted. >> >> 4. SUNWlibtorrent/prototype_com >> >> Why do some include files have the auth '755' instead of 444 ? >> >> >> alex zhang wrote: >>> >>> >>> Begin forwarded message: >>> >>>> From: alex zhang <Huawei.Zhang at Sun.COM> >>>> Date: April 1, 2009 4:38:05 PM GMT+08:00 >>>> To: james.walker at sun.com >>>> Cc: sfwnv-discuss at opensolaris.org >>>> Subject: Code review request >>>> >>>> Hi Jim, >>>> Please help me have a code review of opensolaris package porting, >>>> the webrev at: >>>> http://cr.opensolaris.org/~alz/libtorrent/, which had sent out a >>>> few days without any response. >>>> >>>> Thanks a lot! >>>> - Alex >>> >> >> -- >> Thanks, >> Lizhong >> > -- Thanks, Lizhong
