This looks okay to me paul
David Zhang wrote: > Hi Paul, > > Thanks for your comments. >> David, >> >> The changed file looks okay to me, but do you also need to stop them >> being installed into the ws proto area (ie. in Makefile.sfw or >> install-sfw)? > I use a "ls -l" to get all files from lib, I need to think a way to > avoid installing them into ws proto. > I will update the webrev. >> >> I also noticed these in your SUNWareca/prototype_com files ... >> 127 f none usr/share/areca/AUTHORS 0444 root bin >> 128 f none usr/share/areca/COPYING 0444 root bin > These 2 files are used by areca for licence notice. > > David >> should you be installing these ? >> >> Paul >> >> David Zhang wrote: >>> >>> It is highly appreciate if you could help me to review this update. >>> http://cr.opensolaris.org/~ydzhang/6849015/ >>> >>> Basically, there are some unnecessary linux 32bit .so files need to >>> be removed. >>> Gatekeeper has helped me to make the check_deps clean, than you so >>> much for that. >> >> > -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
