I have done the pv build before and as far as I can see this build 
structure is correct so long as Jim's comments are addressed.

Steve C.



Jim Walker wrote:
> Huajian Luo wrote:
>> Hi there,
>>
>> Would you guys on this list please help me reivew it again.
>>
>> http://cr.opensolaris.org/~hl153459/pv/
>>
> 
> usr/src/cmd/pv/METADATA
> The METADATA file should look like this now:
> http://wikis.sun.com/display/SFWNotes/METADATA
> 
> You should run meta-check on your pkg to make sure
> you have the right format.
> 
> % cd {component-dir} ; make -f Makefile.sfw meta-check
> 
> 
> usr/src/cmd/pv/install-sfw
> - add this statement to handle errors
>  29 set -o errexit
> 
> usr/src/pkgdefs/SUNWpv/pkginfo.tmpl
> - these are better values, and the version is needed
> in the DESC.
>  33 NAME="Pipe Viewer"
>  41 DESC="pipeline monitoring tool (1.1.4)"
> 
> You can use the above values in the METADATA file too.
> 
> Otherwise, this looks good.
> 
> Please send me your PSARC proposal and man page in
> text format and I will sponsor you.
> 
> Cheers,
> Jim
> _______________________________________________
> sfwnv-discuss mailing list
> sfwnv-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
> 

Reply via email to