With the change mentioned by Amanda, it looks good to me too.
George Amanda waite wrote: > 1. usr/src/cmd/sysbench/Makefile.sfw > > Use $(SHELL) instead of ksh93 > > And that's all I have, looks good otherwise > > Amanda > > > Peter Rival wrote: >> Hi all, >> >> It's been over a week since I sent this request, so I'm just sending a >> reminder. Could someone take a bit to review this? Thanks! >> >> - Pete >> >> ------------------------------------------------------------------------ >> >> Subject: >> Code review request for sysbench >> From: >> Peter Rival <peter.rival at sun.com> >> Date: >> Thu, 02 Jul 2009 12:30:13 -0400 >> To: >> sfwnv-discuss at opensolaris.org >> >> To: >> sfwnv-discuss at opensolaris.org >> >> >> Hi all, >> >> I've updated the sysbench bits with the changes for the new METADATA >> format and one change requested by ARC. Could you look it over and >> let me know if there are any needed changes? Thanks! The webrev is >> at: http://cr.opensolaris.org/~frival/sysbench-sfw/ >> >> - Pete >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >> > > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
