Hi Petr, Thanks for reviewing the changes. Please find my comments inline.
Petr Sumbera wrote: > Hi Sonam, > > - You should change version in pkginfo.tmpl file for both packages. Done. > > - I'm not sure what is difference between Makefile.sfw target > install-target-gs and install-target-cups. Don't install both the same > files? install-target-gs installs the gs bits in the proto area whereas install-target-cups installs the cups bits in the proto area. > > - Did you reported to Ghostscript community problem with jpc_qmfb.c > file? Will be this fixed in new version? I have not reported the problem with jpc_qmfb.c file to the Ghostscript community. I will do that. > > Otherwise it looks good to me. > > Maybe one suggestion. There are some python tests script in > toolbin/tests directory. It would be nice to evaluate them and > eventually have them as one Makefile.sfw target. If it make sense... Yes this makes sense. I will take care of that. Webrev ------ http://cr.opensolaris.org/~sonam007/ghostscript_latest/ Thanks & Regards, Sonam > > Regards, > > Petr > > Sonam Gupta wrote: >> Hi, >> >> Can someone please review the changes made for integration of latest >> version of Ghostscript. >> >> Webrev >> ------ >> http://cr.opensolaris.org/~sonam007/ghostscript_latest/ >> >> Thanks & Regards, >> Sonam >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >
