Thank you very much for your feedback. Some responses inline. Amanda waite wrote on Fri Jul 17 2009 14:16:27 GMT-0700 (PDT) : > 1. usr/src/cmd/fakeroot/METADATA > > - SOURCE_DOWNLOAD needs to be the URL of the source tarball, i.e.: > http://ftp.debian.org/debian/pool/main/f/fakeroot/fakeroot_1.11.tar.gz
Ok; will change. > (are you tied in to using 1.11 now, 1.12.4 is available) I'm going by http://packages.qa.debian.org/f/fakeroot.html which indicates that 1.11 is the latest 'stable' version, and 1.12.4 is 'unstable' (in testing as of June 24, 2009). It's my understanding (please correct me if I am wrong) that we only want to integrate stable versions. I'm happy to move to 1.12.4 if that's more appropriate. > 2. usr/src/cmd/fakeroot/Makefile.sfw > > - Use 'env -' instead of 'env' in your 'all' and '$(VER)/config.status' > targets so to start with a clean environment. Accepted; will change. > 3. usr/src/cmd/fakeroot/install-sfw > > - Usually we don't include .la files or static libraries > > _install N .libs/libfakeroot.la ${PREFIX}/lib/libfakeroot.la 555 > _install N .libs/libfakeroot.a ${PREFIX}/lib/libfakeroot.a 555 > > Not sure if this was covered in the Arc case as I can't find a case > number (is there an Arc case?) The ARC proposal is being reviewed, as we speak, by the ARC sponsor, who suggested that I proceed with the code review in the mean time. I was unaware of the restriction on .la/.a files; I looked in the SFW source and there are admittedly very few packages that distribute them. I'll take your comment under advisement and wait for the ARC's decision on this. > 3. usr/src/pkgdefs/Makefile > > - You need to resync your workspace with the clone or the gate. As it > stands at the moment you'll remove the SUNWbindc line Will do. > 4. usr/src/pkgdefs/SUNWfakeroot/prototype_com > > - If you decide not to add the .la and .a files then removve: > > f none usr/lib/libfakeroot.la 555 root bin > f none usr/lib/libfakeroot.a 555 root bin Agreed. I'll let the ARC be the final arbiter on this. > That's all I have, everything else looks ok > > Amanda Thanks, again. -Ravindra. > > UVR wrote: >> >> I am porting the fakeroot utility, a tool to provide a simulated (= >> "fake") >> root environment for file manipulation. A webrev is available at >> http://cr.opensolaris.org/~uvr/fakeroot/ >> >> Please review. Any feedback will be greatly appreciated. >> >> Thanks, >> -UVR. >> _______________________________________________ >> sfwnv-discuss mailing list >> sfwnv-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
