I'm not sure, it was there when I got there. I'll remove it -JohnS On 28-Jul-09, at 2:17 AM, Amanda Waite wrote:
> Why do you use '-p' in the shebang of install-sfw? > > Otherwise it looks good. > > Amanda > > > John Sonnenschein wrote: >> Thank you Amanda. >> >> Updates here: http://cr.opensolaris.org/~error404/6862416_u1 >> >> -JohnS >> >> Amanda Waite wrote: >>> 1. usr/src/pkgdefs/SUNWgnu-coreutils/copyright >>> >>> Changes as discussed on the alias. >>> >>> You also need to add any copyright strings from the source/header >>> files. A good example of what the final file should look like is $ >>> {SRC}/pkgdefs/SUNWlibmcrypt/copyright >>> >>> >>> >>> The others are standard comments that come up for most reviews. >>> >>> 2. usr/src/cmd/coreutils/Makefile.sfw >>> >>> - use 'env -' instead of 'env' so as to start with a clean >>> environment >>> - Set $(VER) from the data in the METADATA file: >>> VER=$(COMPONENT_NAME:sh)-$(COMPONENT_VERSION:sh) >>> >>> 3. usr/src/cmd/coreutils/install-sfw >>> >>> > use /usr/bin/ksh93 or /usr/bin/bash for install-sfw* >>> > and add 'set -o errexit' at the beginning and >>> > replace ". ${SRC}/tools/install.subr" with >>> > "source ${SRC}/tools/install.subr" (the idea is to >>> > catch failures in the script and abort it at that point, >>> > right now the script will just continue) >>> >>> 4. usr/src/pkgdefs/SUNWgnu-coreutils/depend >>> >>> Move the Copyright lines in the header to after the CDDL header >>> and before the ident string. >>> >>> Amanda >>> >>> >>> John Sonnenschein wrote: >>>> Hey again. >>>> >>>> Could I get a code review on this changeset: >>>> http://cr.opensolaris.org/~error404/6862416/ >>>> >>>> much appreciated >>>> -JohnS >>>> _______________________________________________ >>>> sfwnv-discuss mailing list >>>> sfwnv-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss >>> >> >
