Robin, See my comments below ...
Paul tian robin luo wrote: > > I'm porting package "ettcp" to OpenSolaris, it is a tool for measuring > max TCP/UDP bandwidth performance. > Could you please help to review the code? The webrev is at: > http://cr.opensolaris.org/~robinluo/ettcp/ 1. usr/src/pkgdefs/SUNWettcp/prototype_sparc Line ... 46 # List files which are I386 specific here I386 in prototype_sparc file! 2. usr/src/pkgdefs/SUNWettcp/depend Is this the correct set of dependencies, have you checked it with the package dependency checker tool 3. usr/src/pkgdefs/SUNWettcp/copyright Do you need to add source owner copyright lines into this (extracted from the files in the unpacked tarball)? - for example as in (lines 11-18) ... "http://src.opensolaris.org/source/xref/sfw/usr/src/pkgdefs/SUNWmeld/copyright"; 4. usr/src/pkgdefs/Makefile & usr/src/cmd/Makefile These need resyncing with the gate/clone so it doesn't look as though you are trying to change other stuff. 5. usr/src/cmd/ettcp/Makefile.sfw Lines ... 34 CONFIGURE_OPTIONS += PTHREAD_CFLAGS=-pthreads 35 CONFIGURE_OPTIONS += CC=$(CC) are these required/used ? Line ... 44 /usr/bin/gzip -dc $(TARBALL) | tar xopf - change 'tar' to $(TAR) Line ... 38 (cd $(VER); env - CC="$(GCC)" $(CCSMAKE) all) you are only packaging the 'ettcp' bits of the build, so could this have just been '$(CCSMAKE) ettcp' (to save time building the unwanted stuff) ? Have you changed the src package's 'ettcp-1.0/Makefile' to get this to build on solaris (it doesn't build for me as-is from the downloaded tarball using you make invocation) ? 6. usr/src/cmd/ettcp/METADATA Line ... 4 LICENSE: OTHER is 'OTHER' correct? END -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit General Dynamics Itronix Europe Ltd.
