Muktha Narayan wrote:
> Paul Cunningham wrote:
>>
>> This looks good to me, just a single comment, see below ...
>>

>>
>> Muktha Narayan wrote:
>>>
>>> Requesting a code review for Elinks for inclusion into SFW.
>>> Elinks is a text-based web browser.
>>> The webrev is present at http://cr.opensolaris.org/~muktha/elinks/
>>>     
>>
>> 1. usr/src/cmd/elinks/install-sfw
>>      & usr/src/pkgdefs/SUNWelinks/prototype_com
>>     Do the installed *.mo files need the write permission bit set?
>>   
> Most of the packages have installed the *.mo files with 644 permission. 
> Hence I have retained the same.

if you are happy with it like that, then its okay with me (but will it 
get through its RTI like it)

paul
-- 
----------------------------------------------------------------------
Paul Cunningham
Software Engineer
Tadpole Business Unit

Reply via email to